Skip to content

Fix Setbackground for CP7 and add PinAlarm and TouchAlarm support #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 1, 2021
Merged

Fix Setbackground for CP7 and add PinAlarm and TouchAlarm support #53

merged 3 commits into from
Dec 1, 2021

Conversation

makermelissa
Copy link
Collaborator

Fixes #52. If a user uses exit_and_deep_sleep(), it creates a TimeAlarm for backwards compatibility, but also allows for PinAlarm and TouchAlarm.

@makermelissa makermelissa requested a review from a team November 3, 2021 18:53
@makermelissa
Copy link
Collaborator Author

Whoops, guess this became a double PR now. I forgot this wasn't merged yet.

@makermelissa makermelissa changed the title Add PinAlarm and TouchAlarm support Fix Setbackground for CP7 and add PinAlarm and TouchAlarm support Nov 18, 2021
@makermelissa
Copy link
Collaborator Author

Fixes #56

@caternuson
Copy link

I tested this and it does fix #56. Did not test anything w.r.t. #52.

dhalbert
dhalbert approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A number of people are running into the background problem.

@dhalbert dhalbert merged commit 6a94293 into adafruit:main Dec 1, 2021
@dhalbert dhalbert mentioned this pull request Dec 1, 2021
Closed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 2, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@628f852)
c5cd85b 
Updating https://github.com/adafruit/Adafruit_CircuitPython_AVRprog to 1.4.1 from 1.4.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_AVRprog#30 from aarontusko/clock_speed-fix
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.10.0 from 1.9.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#53 from makermelissa/main
  > update rtd py version
@dhalbert dhalbert mentioned this pull request Dec 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add PinAlarm Implementation
3 participants
@makermelissa @caternuson @dhalbert